From mboxrd@z Thu Jan  1 00:00:00 1970
From: Uri Lublin <uril@redhat.com>
Subject: Re: [PATCH] kvm-autotest: log test failed execption string
Date: Sun, 29 Mar 2009 20:15:40 +0300
Message-ID: <49CFACBC.6050900@redhat.com>
References: <20090325164322.GM27104@us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org
To: Ryan Harper <ryanh@us.ibm.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:33900 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751372AbZC2RPp (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 29 Mar 2009 13:15:45 -0400
In-Reply-To: <20090325164322.GM27104@us.ibm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Ryan Harper wrote:
> When a test case fails and throws an execption, we don't log the
> exception details, only that it occured.
> 
> reboot: DEBUG: remote_login: Got password prompt; sending '123456'
> reboot: DEBUG: remote_login: Got shell prompt -- logged in
> reboot: Logged in
> reboot: DEBUG: run_once: Test failed; postprocessing on error...
> reboot: DEBUG: postprocess_vm: Postprocessing VM 'vm1'...
> 
> The attached patch includes the exception text from the failure which makes it
> easier to debug.
> 
> reboot: DEBUG: remote_login: Got password prompt; sending '123456'
> reboot: DEBUG: remote_login: Got shell prompt -- logged in
> reboot: Logged in
> reboot: DEBUG: run_once: Test failed (invalid syntax (kvm_tests.py, line 34)); postprocessing on error...
> reboot: DEBUG: postprocess_vm: Postprocessing VM 'vm1'...
> 
> 
Applied, Thanks.