From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 4/4] Fix task switching. Date: Mon, 30 Mar 2009 10:39:21 +0300 Message-ID: <49D07729.2020400@redhat.com> References: <20090329141202.30481.91797.stgit@trex.usersys.redhat.com> <20090329141218.30481.92675.stgit@trex.usersys.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx2.redhat.com ([66.187.237.31]:35804 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750873AbZC3HjX (ORCPT ); Mon, 30 Mar 2009 03:39:23 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n2U7dMY5013103 for ; Mon, 30 Mar 2009 03:39:22 -0400 In-Reply-To: <20090329141218.30481.92675.stgit@trex.usersys.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Gleb Natapov wrote: > The patch fixes two problems with task switching. > 1. Back link is written to a wrong TSS. > 2. Instruction emulation is not needed if the reason for task switch > is a task gate in IDT and access to it is caused by an external even. > > 2 is currently solved only for VMX since there is not reliable way to > skip an instruction in SVM. We should emulate it instead. > > Looks good, but please split into (at least) two patches. Also please provide a test case so we don't regress again. -- error compiling committee.c: too many arguments to function