From: Avi Kivity <avi@redhat.com>
To: "Dong, Eddie" <eddie.dong@intel.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: Use rsvd_bits_mask in load_pdptrs for cleanup and considing EXB bit
Date: Mon, 30 Mar 2009 15:13:33 +0300 [thread overview]
Message-ID: <49D0B76D.3080304@redhat.com> (raw)
In-Reply-To: <9832F13BD22FB94A829F798DA4A8280501A3C022CF@pdsmsx503.ccr.corp.intel.com>
Dong, Eddie wrote:
> @@ -2199,6 +2194,9 @@ void reset_rsvds_bits_mask(struct kvm_vcpu *vcpu, int level)
> context->rsvd_bits_mask[1][0] = 0;
> break;
> case PT32E_ROOT_LEVEL:
> + context->rsvd_bits_mask[0][2] = exb_bit_rsvd |
> + rsvd_bits(maxphyaddr, 62) |
> + rsvd_bits(7, 8) | rsvd_bits(1, 2); /* PDPTE */
> context->rsvd_bits_mask[0][1] = exb_bit_rsvd |
> rsvd_bits(maxphyaddr, 62); /* PDE */
> context->rsvd_bits_mask[0][0] = exb_bit_rsvd
Are you sure that PDPTEs support NX? They don't support R/W and U/S, so
it seems likely that NX is reserved as well even when EFER.NXE is enabled.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-03-30 12:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9832F13BD22FB94A829F798DA4A8280501A21068EF@pdsmsx503.ccr.corp.intel.com>
2009-03-27 4:19 ` RFC: Add reserved bits check Dong, Eddie
2009-03-27 9:34 ` Avi Kivity
2009-03-27 13:46 ` Dong, Eddie
2009-03-27 13:59 ` Dong, Eddie
2009-03-27 14:28 ` Avi Kivity
2009-03-27 14:42 ` Dong, Eddie
2009-03-29 10:23 ` Avi Kivity
2009-03-30 1:53 ` Dong, Eddie
2009-03-30 2:38 ` Cleanup to reuse is_long_mode() Dong, Eddie
2009-03-30 7:43 ` Avi Kivity
2009-03-30 8:24 ` Dong, Eddie
2009-03-30 11:46 ` Avi Kivity
2009-03-30 2:49 ` Use rsvd_bits_mask in load_pdptrs for cleanup and considing EXB bit Dong, Eddie
2009-03-30 8:27 ` Dong, Eddie
2009-03-30 12:13 ` Avi Kivity [this message]
2009-03-30 13:46 ` Dong, Eddie
2009-03-30 5:12 ` RFC: Add reserved bits check Avi Kivity
2009-03-30 8:21 ` Dong, Eddie
2009-03-30 12:05 ` Avi Kivity
2009-03-31 8:40 ` Avi Kivity
2009-03-31 0:51 FW: Use rsvd_bits_mask in load_pdptrs for cleanup and considing EXB bit Dong, Eddie
2009-03-31 4:12 ` Neiger, Gil
2009-03-31 7:32 ` Dong, Eddie
2009-03-31 8:55 ` Avi Kivity
2009-03-31 15:03 ` Dong, Eddie
2009-04-01 8:28 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D0B76D.3080304@redhat.com \
--to=avi@redhat.com \
--cc=eddie.dong@intel.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox