From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: Biweekly KVM Test report, kernel 0c7771... userspace 1223a0... Date: Mon, 30 Mar 2009 16:55:05 +0300 Message-ID: <49D0CF39.50009@redhat.com> References: <0463F45F3606F4428ED35AC8C709F92E121F6A48@pdsmsx502.ccr.corp.intel.com> <49D06FCE.7030002@redhat.com> <20090330111756.GC26627@amit-x200.pnq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Xu, Jiajun" , "'kvm@vger.kernel.org'" To: Amit Shah Return-path: Received: from mx2.redhat.com ([66.187.237.31]:41656 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750962AbZC3NzI (ORCPT ); Mon, 30 Mar 2009 09:55:08 -0400 In-Reply-To: <20090330111756.GC26627@amit-x200.pnq.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Amit Shah wrote: > On (Mon) Mar 30 2009 [10:07:58], Avi Kivity wrote: > > >>> 1. perfctr wrmsr warning when booting 64bit RHEl5.3 >>> https://sourceforge.net/tracker/?func=detail&aid=2721640&group_id=180599&atid=893831 >>> >> This is the architectural performance counting msr which was enabled in >> 4f76231 (KVM: x86: Ignore reads to EVNTSEL MSRs). Amit, can you check >> if appropriate cpuid leaf 10 reporting will fix this? >> > > We already report 0s for the cpuid leaf 10; we need to report 0x3f in > EBX for leaf 10 to denote events corresponding to the bits aren't > available. > > I checked and it didn't help (we can't rely on guests to abide by cpuid > flags) > I see this in the code: > /* > * Check whether the Architectural PerfMon supports > * Unhalted Core Cycles Event or not. > * NOTE: Corresponding bit = 0 in ebx indicates event present. > */ > cpuid(10, &(eax.full), &ebx, &unused, &unused); > if ((eax.split.mask_length < > (ARCH_PERFMON_UNHALTED_CORE_CYCLES_INDEX+1)) || > (ebx & ARCH_PERFMON_UNHALTED_CORE_CYCLES_PRESENT)) > return 0; > So I think it can be done. -- error compiling committee.c: too many arguments to function