From: Jan Kiszka <jan.kiszka@web.de>
To: Gleb Natapov <gleb@redhat.com>
Cc: avi@redhat.com, kvm@vger.kernel.org,
Bernhard Kohl <bernhard.kohl@nsn.com>,
"Ostler, Thomas (NSN - DE/Munich)" <thomas.ostler@nsn.com>,
bliitz@users.sourceforge.net
Subject: Re: [PATCH 4/4] Fix task switching.
Date: Mon, 30 Mar 2009 18:35:05 +0200 [thread overview]
Message-ID: <49D0F4B9.5040008@web.de> (raw)
In-Reply-To: <20090330162155.GI25718@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1318 bytes --]
Gleb Natapov wrote:
> On Mon, Mar 30, 2009 at 06:04:45PM +0200, Jan Kiszka wrote:
>> Gleb Natapov wrote:
>>> The patch fixes two problems with task switching.
>>> 1. Back link is written to a wrong TSS.
>>> 2. Instruction emulation is not needed if the reason for task switch
>>> is a task gate in IDT and access to it is caused by an external even.
>>>
>>> 2 is currently solved only for VMX since there is not reliable way to
>>> skip an instruction in SVM. We should emulate it instead.
>> Does this series fix all issues Bernhard, Thomas and Julian stumbled over?
>>
> Haven't tried. I wrote my own tests for task switching. How can I check it?
>
There is a test case attached to Julian's sourceforge-reported bug:
https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2681442&group_id=180599
And I guess Thomas or Bernhard will be happy to give it a try, too... :)
There was one issue, the IRQ injection bug [1] which was related to IRQ
tasks IIRC. Thomas and I finally suspected after a private chat that
there is actually a different reason behind it, something like
interrupt.pending should be cleared when the injection took place via an
(emulated) task switch. Any news on this, Thomas?
Jan
[1] http://permalink.gmane.org/gmane.comp.emulators.kvm.devel/29288
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
next prev parent reply other threads:[~2009-03-30 16:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-29 14:12 [PATCH 1/4] Fix handling of a fault during NMI unblocked due to IRET Gleb Natapov
2009-03-29 14:12 ` [PATCH 2/4] Rewrite twisted maze of if() statements with more straightforward switch() Gleb Natapov
2009-03-30 7:35 ` Avi Kivity
2009-03-30 16:03 ` Jan Kiszka
2009-03-29 14:12 ` [PATCH 3/4] Do not zero idt_vectoring_info in vmx_complete_interrupts() Gleb Natapov
2009-03-29 14:12 ` [PATCH 4/4] Fix task switching Gleb Natapov
2009-03-30 7:39 ` Avi Kivity
2009-03-30 13:06 ` Gleb Natapov
2009-03-30 16:04 ` Jan Kiszka
2009-03-30 16:21 ` Gleb Natapov
2009-03-30 16:35 ` Jan Kiszka [this message]
2009-03-30 16:39 ` Gleb Natapov
2009-03-30 16:46 ` Gleb Natapov
2009-03-30 23:54 ` Julian Stecklina
2009-03-31 9:03 ` Kohl, Bernhard (NSN - DE/Munich)
2009-03-31 15:21 ` Kohl, Bernhard (NSN - DE/Munich)
2009-03-31 15:22 ` Gleb Natapov
2009-04-01 7:21 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D0F4B9.5040008@web.de \
--to=jan.kiszka@web.de \
--cc=avi@redhat.com \
--cc=bernhard.kohl@nsn.com \
--cc=bliitz@users.sourceforge.net \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=thomas.ostler@nsn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox