* [PATCH] KVM: Qemu: Do not use log dirty in IA64
@ 2009-03-27 3:55 Zhang, Yang
2009-04-01 8:58 ` Avi Kivity
0 siblings, 1 reply; 3+ messages in thread
From: Zhang, Yang @ 2009-03-27 3:55 UTC (permalink / raw)
To: kvm-ia64@vger.kernel.org; +Cc: kvm@vger.kernel.org, Avi Kivity, Zhang, Xiantao
[-- Attachment #1: Type: text/plain, Size: 973 bytes --]
hi
please checkin it to kvm85, thanks!
IA64 does not support log dirty. We should not use it
in IA64, or it will have some problem.
Signed-off-by: Yang Zhang <yang.zhang@intel.com>
---
qemu/qemu-kvm.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/qemu/qemu-kvm.c b/qemu/qemu-kvm.c
index 4164368..ed76367 100644
--- a/qemu/qemu-kvm.c
+++ b/qemu/qemu-kvm.c
@@ -1374,7 +1374,10 @@ int kvm_log_start(target_phys_addr_t phys_addr, target_phys_addr_t len)
if (must_use_aliases_source(phys_addr))
return 0;
#endif
+
+#ifndef TARGET_IA64
kvm_qemu_log_memory(phys_addr, len, 1);
+#endif
return 0;
}
@@ -1384,7 +1387,10 @@ int kvm_log_stop(target_phys_addr_t phys_addr, target_phys_addr_t len)
if (must_use_aliases_source(phys_addr))
return 0;
#endif
+
+#ifndef TARGET_IA64
kvm_qemu_log_memory(phys_addr, len, 0);
+#endif
return 0;
}
--
1.6.0.rc1
[-- Attachment #2: 0001-KVM-Qemu-Do-not-use-log-dirty-in-IA64.patch --]
[-- Type: application/octet-stream, Size: 1097 bytes --]
From ad482ea5b23e1f6796e8a41964e7f5cedff0b231 Mon Sep 17 00:00:00 2001
From: Yang Zhang <yang.zhang@intel.com>
Date: Thu, 26 Mar 2009 22:13:06 -0400
Subject: [PATCH] KVM: Qemu: Do not use log dirty in IA64
IA64 does not support log dirty. We should not use it
in IA64, or it will have some problem.
Signed-off-by: Yang Zhang <yang.zhang@intel.com>
---
qemu/qemu-kvm.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/qemu/qemu-kvm.c b/qemu/qemu-kvm.c
index 4164368..ed76367 100644
--- a/qemu/qemu-kvm.c
+++ b/qemu/qemu-kvm.c
@@ -1374,7 +1374,10 @@ int kvm_log_start(target_phys_addr_t phys_addr, target_phys_addr_t len)
if (must_use_aliases_source(phys_addr))
return 0;
#endif
+
+#ifndef TARGET_IA64
kvm_qemu_log_memory(phys_addr, len, 1);
+#endif
return 0;
}
@@ -1384,7 +1387,10 @@ int kvm_log_stop(target_phys_addr_t phys_addr, target_phys_addr_t len)
if (must_use_aliases_source(phys_addr))
return 0;
#endif
+
+#ifndef TARGET_IA64
kvm_qemu_log_memory(phys_addr, len, 0);
+#endif
return 0;
}
--
1.6.0.rc1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] KVM: Qemu: Do not use log dirty in IA64
2009-03-27 3:55 [PATCH] KVM: Qemu: Do not use log dirty in IA64 Zhang, Yang
@ 2009-04-01 8:58 ` Avi Kivity
2009-04-01 10:13 ` Zhang, Xiantao
0 siblings, 1 reply; 3+ messages in thread
From: Avi Kivity @ 2009-04-01 8:58 UTC (permalink / raw)
To: Zhang, Yang; +Cc: kvm-ia64@vger.kernel.org, kvm@vger.kernel.org, Zhang, Xiantao
Zhang, Yang wrote:
> hi
> please checkin it to kvm85, thanks!
>
> IA64 does not support log dirty. We should not use it
> in IA64, or it will have some problem.
>
Applied, thanks. When are you planning to add support for log dirty on
ia64?
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] KVM: Qemu: Do not use log dirty in IA64
2009-04-01 8:58 ` Avi Kivity
@ 2009-04-01 10:13 ` Zhang, Xiantao
0 siblings, 0 replies; 3+ messages in thread
From: Zhang, Xiantao @ 2009-04-01 10:13 UTC (permalink / raw)
To: Avi Kivity, Zhang, Yang; +Cc: kvm-ia64@vger.kernel.org, kvm@vger.kernel.org
Avi Kivity wrote:
> Zhang, Yang wrote:
>> hi
>> please checkin it to kvm85, thanks!
>>
>> IA64 does not support log dirty. We should not use it
>> in IA64, or it will have some problem.
>>
>
> Applied, thanks. When are you planning to add support for log dirty
> on ia64?
We had the patch at hand, but still there are other issues which block upstream, so hadn't tested it yet.
Xiantao
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-04-01 10:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-27 3:55 [PATCH] KVM: Qemu: Do not use log dirty in IA64 Zhang, Yang
2009-04-01 8:58 ` Avi Kivity
2009-04-01 10:13 ` Zhang, Xiantao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox