From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/2] kvm: qemu: check device assignment command Date: Wed, 01 Apr 2009 12:18:49 +0300 Message-ID: <49D33179.7010905@redhat.com> References: <715D42877B251141A38726ABF5CABF2C01A11B66EE@pdsmsx503.ccr.corp.intel.com> <49CB6F55.10603@redhat.com> <715D42877B251141A38726ABF5CABF2C01A11B6AB9@pdsmsx503.ccr.corp.intel.com> <49CF8716.4060300@redhat.com> <715D42877B251141A38726ABF5CABF2C01A2DC03D6@pdsmsx503.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "'kvm@vger.kernel.org'" To: "Han, Weidong" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:33243 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751962AbZDAJSM (ORCPT ); Wed, 1 Apr 2009 05:18:12 -0400 In-Reply-To: <715D42877B251141A38726ABF5CABF2C01A2DC03D6@pdsmsx503.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Han, Weidong wrote: > pci_parse_devaddr parses [[:][:], it's valid when even enter only slot, whereas it must be bus:slot.func in device assignment command (-pcidevice host=bus:slot.func). So I implemented a dedicated function to parse device bdf in device assignment command, rather than mix two parsing function together. > > Applied, thanks. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.