From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: Qemu: Flush i-cache after ide-dma operation in IA64 Date: Fri, 03 Apr 2009 14:06:11 +0300 Message-ID: <49D5EDA3.7060709@redhat.com> References: <10C63FAD690C13458F0B32BCED571F140F98ED4B@pdsmsx502.ccr.corp.intel.com> <49D47D7F.2040904@redhat.com> <706158FABBBA044BAD4FE898A02E4BC2326A0CC6@pdsmsx503.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Zhang, Yang" , "kvm-ia64@vger.kernel.org" , "kvm@vger.kernel.org" To: "Zhang, Xiantao" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:54233 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756420AbZDCLFg (ORCPT ); Fri, 3 Apr 2009 07:05:36 -0400 In-Reply-To: <706158FABBBA044BAD4FE898A02E4BC2326A0CC6@pdsmsx503.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Zhang, Xiantao wrote: >> This is the wrong place to put this. Once we stop bouncing >> scatter/gather DMA, we will no longer call this function. >> > > This patch intends to fix the issue before adopting scatter/gather DMA mode. But if we want to keep this funtion, had better to pick it to avoid such issues in future. > > This function is the wrong place, it just happens to be called. >> The correct place is either in the device code itself, or in the dma >> api (dma-helpers.c). >> > > Maybe dma-helpers.c Please send a patch with this in dma-helpers.c. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.