Re: [PATCH] kvm-autotest: stepeditor: clear image if width, height, or data are invalid

[Avi Kivity <avi@redhat.com>]

Eduardo Habkost wrote:
>>>>> SPACE_RGB, False, 8,  w, h, w*3)
>>>>>           
>> Traceback (most recent call last):
>>   File "<stdin>", line 1, in ?
>> MemoryError
>>     
>
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  client/tests/kvm_runtest_2/stepeditor.py |   14 +++++++++-----
>  1 files changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/client/tests/kvm_runtest_2/stepeditor.py b/client/tests/kvm_runtest_2/stepeditor.py
> index caaf47b..383834b 100755
> --- a/client/tests/kvm_runtest_2/stepeditor.py
> +++ b/client/tests/kvm_runtest_2/stepeditor.py
> @@ -488,14 +488,18 @@ Utilities
>          vscrollbar = self.scrolledwindow.get_vscrollbar()
>          vscrollbar.set_range(0, h)
>  
> +    def clear_image(self):
> +        self.image.clear()
> +        self.image_width = 0
> +        self.image_height = 0
> +        self.image_data = ""
> +        
>      def set_image_from_file(self, filename):
>          if not filename or not os.path.exists(filename):
> -            self.image.clear()
> -            self.image_width = 0
> -            self.image_height = 0
> -            self.image_data = ""
> -            return
> +            return self.clear_image()
>          (w, h, data) = ppm_utils.image_read_from_ppm_file(filename)
> +        if w <= 0 or h <= 0 or not data:
> +            return self.clear_image()
>          self.set_image(w, h, data)
>   

Instead of returning an empty image here, we should throw an exception.  
Qemu shouldn't write invalid image.

I've just sent a patch to qemu-devel which may help with this.

-- 
error compiling committee.c: too many arguments to function