From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH] Fix display breakage when resizing the screen (v2) Date: Sun, 05 Apr 2009 13:45:37 -0500 Message-ID: <49D8FC51.3010709@us.ibm.com> References: <1238945808-13027-1-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from e36.co.us.ibm.com ([32.97.110.154]:41092 "EHLO e36.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751961AbZDESpm (ORCPT ); Sun, 5 Apr 2009 14:45:42 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e36.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n35IiF0g027015 for ; Sun, 5 Apr 2009 12:44:15 -0600 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n35IjeQo063088 for ; Sun, 5 Apr 2009 12:45:40 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n35IjdYE017556 for ; Sun, 5 Apr 2009 12:45:40 -0600 In-Reply-To: <1238945808-13027-1-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: > When the vga resolution changes, a new display surface is not allocated > immediately; instead that is deferred until the next update. However, > if we're running without a display client attached, that won't happen > and the next bitblt is likely to cause a segfault by overflowing the > display surface. > > Fix by reallocating the display immediately when the resolution changes. > > Tested with (Windows|Linux) x (cirrus|std) x (curses|sdl). > > Changes from v1: > - fix segfault when switching virtual consoles with curses > > Signed-off-by: Avi Kivity > Applied. Thanks. -- Regards, Anthony Liguori