From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <aliguori@us.ibm.com>
Subject: Re: [PATCH 2/2] qemu:bios: Read external SMBIOS entries from the
 VM
Date: Mon, 06 Apr 2009 14:52:40 -0500
Message-ID: <49DA5D88.3010201@us.ibm.com>
References: <1237835133.7276.1107.camel@lappy> <1237835467.15558.5.camel@lappy>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: qemu-devel <qemu-devel@nongnu.org>, kvm <kvm@vger.kernel.org>
To: Alex Williamson <alex.williamson@hp.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from e1.ny.us.ibm.com ([32.97.182.141]:54213 "EHLO e1.ny.us.ibm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751989AbZDFTwp (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 6 Apr 2009 15:52:45 -0400
Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234])
	by e1.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n36Jnf9I019838
	for <kvm@vger.kernel.org>; Mon, 6 Apr 2009 15:49:41 -0400
Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216])
	by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n36JqhhW191792
	for <kvm@vger.kernel.org>; Mon, 6 Apr 2009 15:52:43 -0400
Received: from d01av02.pok.ibm.com (loopback [127.0.0.1])
	by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n36Jp59B030443
	for <kvm@vger.kernel.org>; Mon, 6 Apr 2009 15:51:06 -0400
In-Reply-To: <1237835467.15558.5.camel@lappy>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Alex Williamson wrote:
> SMBIOS entries can be read from the VM using the same mechanism
> as additional ACPI tables.  External entries will supercede
> generated entries.
>
> Signed-off-by: Alex Williamson <alex.williamson@hp.com>
> +
> +        /* A type 1 entry provides a UUID, but so does the QEMU_CFG_UUID
> +         * port.  If the QEMU_CFG_UUID value is not zero, use it, otherwise
> +         * use whatever was in the provided table. */
> +        if (type == 1) {
> +            const static uint8_t null_uuid[16] = { 0 };
> +            if (memcmp(bios_uuid, null_uuid, 16)) {
> +                struct smbios_type_1 *t = (struct smbios_type_1 *)*q;
> +                memcpy(t->uuid, bios_uuid, 16);
> +            }
> +        }
>   

This is what I was getting at in my other post.  I'd sort of rather that 
a certain set of SMBIOS tables be specified at a higher level (like 
uuid, manufacture, vendor, etc.) and the blobs just be the OEM tables.  
I think that matches the work going on with the device configuration 
files more appropriately.

Regards,

Anthony Liguori