From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] disable interrupt shadow state for emulated instruction Date: Thu, 09 Apr 2009 10:39:59 +0300 Message-ID: <49DDA64F.9020000@redhat.com> References: <1239213452-5966-1-git-send-email-glommer@redhat.com> <49DCE9E5.8020703@zytor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Glauber Costa , kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: "H. Peter Anvin" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:56373 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757222AbZDIHjW (ORCPT ); Thu, 9 Apr 2009 03:39:22 -0400 In-Reply-To: <49DCE9E5.8020703@zytor.com> Sender: kvm-owner@vger.kernel.org List-ID: H. Peter Anvin wrote: > > How does this logic work when the instruction emulated is an STI or > MOV SS instruction? In particular, when does > GUEST_INTERRUPTIBILITY_INFO sets set to reflect the *blocking* operation? The processor sets it when emulating an sti or mov ss instruction. We ought to set it when emulating same. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.