From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 1/1] kvm: don't check per-vector mask bit before enable
 MSI-X
Date: Thu, 09 Apr 2009 18:29:28 +0300
Message-ID: <49DE1458.8090300@redhat.com>
References: <1239241259-23146-1-git-send-email-sheng@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, Alex Williamson <alex.williamson@hp.com>
To: Sheng Yang <sheng@linux.intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:36302 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S935255AbZDIP3h (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 9 Apr 2009 11:29:37 -0400
In-Reply-To: <1239241259-23146-1-git-send-email-sheng@linux.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Sheng Yang wrote:
> Some driver(e.g. bnx2) do the following to enable MSI-X:
> 1. Mask all vectors.
> 2. Write the msg data and address.
> 3. Enable MSI-X
> 4. Unmask all the vectors.
>
> For this, check per-vector mask bit before enable MSI-X would cause device
> fail to enable MSI-X. So now we only determine the availability of vector
> by if msg_data is zero.
>   

Applied, thanks.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.