From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: KVM: PIT: fix count read and mode 0 handling
Date: Thu, 09 Apr 2009 18:30:08 +0300
Message-ID: <49DE1480.6000907@redhat.com>
References: <49DB5AE8.7090009@redhat.com> <20090408161419.GA16804@amt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: KVM list <kvm@vger.kernel.org>,
	Alexey Eromenko <aeromenk@redhat.com>,
	"Yang, Sheng" <sheng.yang@intel.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:49155 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S935326AbZDIPaR (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 9 Apr 2009 11:30:17 -0400
In-Reply-To: <20090408161419.GA16804@amt.cnet>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Marcelo Tosatti wrote:
> Commit 46ee278652f4cbd51013471b64c7897ba9bcd1b1 causes Solaris 10 
> to hang on boot.
>
> Assuming that PIT counter reads should return 0 for an expired timer
> is wrong: when it is active, the counter never stops (see comment on
> __kpit_elapsed).
>
> Also arm a one shot timer for mode 0.
>   

Applied, thanks.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.