From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Add MCE support to KVM Date: Tue, 14 Apr 2009 13:45:15 +0300 Message-ID: <49E4693B.4080707@redhat.com> References: <1239155601.6384.3.camel@yhuang-dev.sh.intel.com> <49DE195D.1020303@redhat.com> <1239332455.6384.108.camel@yhuang-dev.sh.intel.com> <49E08762.1010206@redhat.com> <1239590499.6384.4016.camel@yhuang-dev.sh.intel.com> <49E337D7.5050502@redhat.com> <1239674697.20762.34.camel@yhuang-dev.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Andi Kleen To: Huang Ying Return-path: Received: from mx2.redhat.com ([66.187.237.31]:57204 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751599AbZDNKol (ORCPT ); Tue, 14 Apr 2009 06:44:41 -0400 In-Reply-To: <1239674697.20762.34.camel@yhuang-dev.sh.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Huang Ying wrote: >> I'm okay with an ioctl to setup MCE, but just make sure userspace has >> all the information to know what the kernel can do rather than the >> try-and-see-if-it-works approach. We can publish this information via >> KVM_CAP things, or via another ioctl (see KVM_GET_SUPPORTED_CPUID2 for >> an example). >> > > Yes. MCE support should be published by KVM_CAP_MCE and other features > can be published via reading the default value of MSR_IA32_MCG_CAP. > A problem with this is that you can only read an MSR after a vcpu has been created. But if you're writing a program to detect what features are available (for example, when checking features common to a migration pool), you don't want to create a vpcu (you could, but it's hacky). -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.