From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 13/15] Add NMI injection support to SVM.
Date: Sun, 19 Apr 2009 16:43:12 +0300
Message-ID: <49EB2A70.5020200@redhat.com>
References: <1239616545-25199-1-git-send-email-gleb@redhat.com> <1239616545-25199-14-git-send-email-gleb@redhat.com> <49E8DEC1.4030802@web.de> <20090419131735.GG10126@redhat.com> <49EB26BA.9020200@web.de> <20090419133222.GK10126@redhat.com> <49EB29E3.5030901@redhat.com> <20090419134143.GM10126@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Jan Kiszka <jan.kiszka@web.de>, kvm@vger.kernel.org,
	joerg.roedel@amd.com, sheng@linux.intel.com,
	Dmitry Baryshkov <dbaryshkov@gmail.com>
To: Gleb Natapov <gleb@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:43528 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932160AbZDSNnX (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 19 Apr 2009 09:43:23 -0400
In-Reply-To: <20090419134143.GM10126@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Gleb Natapov wrote:
> On Sun, Apr 19, 2009 at 04:40:51PM +0300, Avi Kivity wrote:
>   
>> Gleb Natapov wrote:
>>     
>>>> It's OK as a first step towards correct NMI emulation. Additionally, you
>>>> could enable the IRQ window interception in case the is an NMI pending.
>>>> The resulting behavior should then much like the VNMI mask emulation for
>>>> vmx.
>>>>
>>>>     
>>>>         
>>> Yeah, but the question is if IRQ windows is already opened will exit
>>> happens before or after IRET.
>>>   
>>>       
>> You mean if the NMI handler enabled interrupts?
>>
>>     
> Yes.
>
>   

Then the guest deserves whatever it gets...

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.