From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 13/15] Add NMI injection support to SVM. Date: Sun, 19 Apr 2009 15:43:41 +0200 Message-ID: <49EB2A8D.603@web.de> References: <1239616545-25199-1-git-send-email-gleb@redhat.com> <1239616545-25199-14-git-send-email-gleb@redhat.com> <49E8DEC1.4030802@web.de> <20090419131735.GG10126@redhat.com> <49EB2559.4000704@redhat.com> <20090419132434.GH10126@redhat.com> <49EB26E9.4060002@redhat.com> <20090419134005.GL10126@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigE8CE00555A0668D826BCF392" Cc: Avi Kivity , kvm@vger.kernel.org, joerg.roedel@amd.com, sheng@linux.intel.com, Dmitry Baryshkov To: Gleb Natapov Return-path: Received: from fmmailgate03.web.de ([217.72.192.234]:39781 "EHLO fmmailgate03.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761527AbZDSNnn (ORCPT ); Sun, 19 Apr 2009 09:43:43 -0400 In-Reply-To: <20090419134005.GL10126@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigE8CE00555A0668D826BCF392 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Gleb Natapov wrote: > On Sun, Apr 19, 2009 at 04:28:09PM +0300, Avi Kivity wrote: >> Gleb Natapov wrote: >>>> There may not be a next entry if the guest is in a tight loop. Give= n=20 >>>> NMIs are used for watchdogs, that's not good. >>>> >>>> =20 >>> We don't exit a guest after kvm time slice ends? >>> =20 >> There are no time slices any more. If there's only once thread for a = =20 >> vcpu, you might have no exits at all with a tickless kernel. >> > Well, KVM may request some kind of even (timer) that will cause exit to= > VCPU. This looks hacky though. We already spent to much electrons and brain cycles on possibly "much simpler" workarounds. I think injecting and handling a single-step, even while there is guest debugging going on or the guest itself single-steps or both, will not be more complicated - but "more correct". Jan --------------enigE8CE00555A0668D826BCF392 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAknrKo4ACgkQniDOoMHTA+nRogCfas87eLxCNs+uerN+RYq6+Oie tDoAn3yLke+52ylhtQg36HR7faDdyNgL =6tHa -----END PGP SIGNATURE----- --------------enigE8CE00555A0668D826BCF392--