From: Avi Kivity <avi@redhat.com>
To: Gregory Haskins <ghaskins@novell.com>
Cc: kvm@vger.kernel.org, Sheng Yang <sheng@linux.intel.com>
Subject: Re: [PATCH] qemu: fix pci_enable_capabilities to set the CAP feature in pci::status
Date: Tue, 21 Apr 2009 17:53:17 +0300 [thread overview]
Message-ID: <49EDDDDD.1020605@redhat.com> (raw)
In-Reply-To: <20090420152007.11870.76689.stgit@dev.haskins.net>
Gregory Haskins wrote:
> (Applies to kvm-userspace.git:a1075de527f309850df278484f2ef4127827c6f4)
>
> The PCI spec requires bit 4 of the config-space STATUS register to be set
> in order to indicate that the capabilities pointer and capabilities area are
> valid. We have a pci_enable_capabilities() routine to fill out the
> config-space metadata, but we leave the status bit cleared. It is not
> apparent if this was intentionally omitted as part of the related
> device-assignment support, or simply an oversight. This patch completes
> the function by also setting the status bit appropriately.
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2009-04-21 14:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-20 15:20 [PATCH] qemu: fix pci_enable_capabilities to set the CAP feature in pci::status Gregory Haskins
2009-04-21 14:53 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49EDDDDD.1020605@redhat.com \
--to=avi@redhat.com \
--cc=ghaskins@novell.com \
--cc=kvm@vger.kernel.org \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox