From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] qemu: fix pci_enable_capabilities to set the CAP feature in pci::status Date: Tue, 21 Apr 2009 17:53:17 +0300 Message-ID: <49EDDDDD.1020605@redhat.com> References: <20090420152007.11870.76689.stgit@dev.haskins.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Sheng Yang To: Gregory Haskins Return-path: Received: from mx2.redhat.com ([66.187.237.31]:44214 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017AbZDUOxX (ORCPT ); Tue, 21 Apr 2009 10:53:23 -0400 In-Reply-To: <20090420152007.11870.76689.stgit@dev.haskins.net> Sender: kvm-owner@vger.kernel.org List-ID: Gregory Haskins wrote: > (Applies to kvm-userspace.git:a1075de527f309850df278484f2ef4127827c6f4) > > The PCI spec requires bit 4 of the config-space STATUS register to be set > in order to indicate that the capabilities pointer and capabilities area are > valid. We have a pci_enable_capabilities() routine to fill out the > config-space metadata, but we leave the status bit cleared. It is not > apparent if this was intentionally omitted as part of the related > device-assignment support, or simply an oversight. This patch completes > the function by also setting the status bit appropriately. > Applied, thanks. -- error compiling committee.c: too many arguments to function