From: Avi Kivity <avi@redhat.com>
To: Hollis Blanchard <hollisb@us.ibm.com>
Cc: kvm@vger.kernel.org, Xiantao Zhang <xiantao.zhang@intel.com>
Subject: Re: [PATCH] kvm: qemu: Sync idcache after emualted DMA operations for ia64
Date: Tue, 21 Apr 2009 23:06:29 +0300 [thread overview]
Message-ID: <49EE2745.9040408@redhat.com> (raw)
In-Reply-To: <1240342120.29455.10.camel@slate.austin.ibm.com>
Hollis Blanchard wrote:
>> So I can release kvm-85. I don't like it either.
>>
>
> You don't need to commit it:
> 1. KVM on ia64 has made it for this long without that patch.
>
Apparently, this was triggered by recent changes to the dma-api? Xiantao?
> 2. The ia64 guys didn't even reply, much less revise the patch.
>
See below.
> 3. The patch quality is clearly not high enough to be committed to
> qemu (at least, one would hope), so you're just going to have to
> revert it to apply a better fix anyways.
>
I agree that the patch is not correct. If it is not fixed by the end of
this month, you may send a patch to revert this change.
> I don't see why all ia64 patches had to be applied for kvm-85,
> regardless of merit.
>
I like to make releases that are not useless. For that I sometimes have
to resort to band-aids. Comments like yours about the quality of these
band aids will be addressed.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2009-04-21 20:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090421100852.8B1EE250AE4@cleopatra.tlv.redhat.com>
2009-04-21 16:19 ` [PATCH] kvm: qemu: Sync idcache after emualted DMA operations for ia64 Hollis Blanchard
2009-04-21 17:21 ` Avi Kivity
2009-04-21 19:28 ` Hollis Blanchard
2009-04-21 20:06 ` Avi Kivity [this message]
2009-05-01 20:18 ` [PATCH] Revert "Sync idcache after emualted DMA operations for ia64" Hollis Blanchard
2009-05-03 16:12 ` Avi Kivity
2009-05-04 1:39 ` Zhang, Xiantao
2009-05-04 16:52 ` [PATCH] Revert "Sync idcache after emualted DMA operations foria64" Hollis Blanchard
2009-04-22 1:59 ` [PATCH] kvm: qemu: Sync idcache after emualted DMA operations for ia64 Zhang, Xiantao
2009-04-22 15:58 ` Hollis Blanchard
2009-04-24 7:45 ` Zhang, Xiantao
2009-04-24 15:15 ` Hollis Blanchard
2009-04-24 15:37 ` Zhang, Xiantao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49EE2745.9040408@redhat.com \
--to=avi@redhat.com \
--cc=hollisb@us.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=xiantao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox