From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm: qemu: Sync idcache after emualted DMA operations for ia64 Date: Tue, 21 Apr 2009 23:06:29 +0300 Message-ID: <49EE2745.9040408@redhat.com> References: <20090421100852.8B1EE250AE4@cleopatra.tlv.redhat.com> <1240330773.29455.3.camel@slate.austin.ibm.com> <49EE0089.2090908@redhat.com> <1240342120.29455.10.camel@slate.austin.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Xiantao Zhang To: Hollis Blanchard Return-path: Received: from mx2.redhat.com ([66.187.237.31]:49344 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751956AbZDUUGg (ORCPT ); Tue, 21 Apr 2009 16:06:36 -0400 In-Reply-To: <1240342120.29455.10.camel@slate.austin.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: Hollis Blanchard wrote: >> So I can release kvm-85. I don't like it either. >> > > You don't need to commit it: > 1. KVM on ia64 has made it for this long without that patch. > Apparently, this was triggered by recent changes to the dma-api? Xiantao? > 2. The ia64 guys didn't even reply, much less revise the patch. > See below. > 3. The patch quality is clearly not high enough to be committed to > qemu (at least, one would hope), so you're just going to have to > revert it to apply a better fix anyways. > I agree that the patch is not correct. If it is not fixed by the end of this month, you may send a patch to revert this change. > I don't see why all ia64 patches had to be applied for kvm-85, > regardless of merit. > I like to make releases that are not useless. For that I sometimes have to resort to band-aids. Comments like yours about the quality of these band aids will be addressed. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.