From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: kvm: qemu: net: drop packet from tap device if all NICs are down Date: Thu, 23 Apr 2009 18:24:51 +0300 Message-ID: <49F08843.600@redhat.com> References: <1240412194.7661.22.camel@blaa> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm , Yan Vugenfirer To: Mark McLoughlin Return-path: Received: from mx2.redhat.com ([66.187.237.31]:51517 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751180AbZDWPZB (ORCPT ); Thu, 23 Apr 2009 11:25:01 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n3NFOrnM009110 for ; Thu, 23 Apr 2009 11:24:53 -0400 In-Reply-To: <1240412194.7661.22.camel@blaa> Sender: kvm-owner@vger.kernel.org List-ID: Mark McLoughlin wrote: > If you do e.g. "set_link virtio.0 down" and there are packets > pending on the tap interface, we currently buffer a packet > and constantly try and send it until the link is up again. > > We actually just want to drop the packet if the NIC is down. > Upstream qemu already does this, we just differ because we > buffer packets from the tap interface. > > Applied, thanks. -- error compiling committee.c: too many arguments to function