From: Anthony Liguori <anthony@codemonkey.ws>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Jan Kiszka <jan.kiszka@web.de>, Avi Kivity <avi@redhat.com>,
kvm-devel <kvm@vger.kernel.org>
Subject: Re: [PATCH] kvm-userspace: Make PC speaker emulation aware of in-kernel PIT
Date: Sat, 25 Apr 2009 08:08:37 -0500 [thread overview]
Message-ID: <49F30B55.6050207@codemonkey.ws> (raw)
In-Reply-To: <20090425001319.GB15144@amt.cnet>
Marcelo Tosatti wrote:
> Jan,
>
> While the patch itself looks fine, IMO it would be better to move all of
> the timer handling to userspace, except the performance critical parts,
> since most of it is generic. Either periodic or one-shot timer, with:
>
The reason for having the PIT in-kernel is not performance. The PIT is
not performance sensitive.
It's because it was easier to do interrupt catch-up by pushing the PIT
into the kernel which IMHO was the wrong path to go down.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-04-25 13:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 20:24 [PATCH] kvm-userspace: Make PC speaker emulation aware of in-kernel PIT Jan Kiszka
2009-04-25 0:13 ` Marcelo Tosatti
2009-04-25 13:08 ` Anthony Liguori [this message]
2009-04-25 16:28 ` Jan Kiszka
2009-04-25 19:59 ` Anthony Liguori
2009-04-27 13:00 ` Sheng Yang
2009-04-28 4:44 ` David S. Ahern
2009-04-28 7:02 ` Dor Laor
2009-04-27 22:32 ` Marcelo Tosatti
2009-05-04 9:34 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F30B55.6050207@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox