From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH] kvm-userspace: Make PC speaker emulation aware of in-kernel PIT Date: Sat, 25 Apr 2009 08:08:37 -0500 Message-ID: <49F30B55.6050207@codemonkey.ws> References: <49F0CE65.4050005@web.de> <20090425001319.GB15144@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Jan Kiszka , Avi Kivity , kvm-devel To: Marcelo Tosatti Return-path: Received: from an-out-0708.google.com ([209.85.132.243]:17415 "EHLO an-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752806AbZDYNIm (ORCPT ); Sat, 25 Apr 2009 09:08:42 -0400 Received: by an-out-0708.google.com with SMTP id d40so963446and.1 for ; Sat, 25 Apr 2009 06:08:40 -0700 (PDT) In-Reply-To: <20090425001319.GB15144@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: Marcelo Tosatti wrote: > Jan, > > While the patch itself looks fine, IMO it would be better to move all of > the timer handling to userspace, except the performance critical parts, > since most of it is generic. Either periodic or one-shot timer, with: > The reason for having the PIT in-kernel is not performance. The PIT is not performance sensitive. It's because it was easier to do interrupt catch-up by pushing the PIT into the kernel which IMHO was the wrong path to go down. Regards, Anthony Liguori