From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] thinko fix: move memset to after mmap failure check Date: Sun, 26 Apr 2009 14:52:12 +0300 Message-ID: <49F44AEC.5060801@redhat.com> References: <20090426114638.GA27129@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: "Michael S. Tsirkin" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:46386 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750710AbZDZLwO (ORCPT ); Sun, 26 Apr 2009 07:52:14 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n3QBqE6q027892 for ; Sun, 26 Apr 2009 07:52:14 -0400 In-Reply-To: <20090426114638.GA27129@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Michael S. Tsirkin wrote: > By the time we've done a memset, it's too late to > check the pointer for MAP_FAILED value. Let's compare > to MAP_FAILED first. > > Applied, thanks. -- error compiling committee.c: too many arguments to function