From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [PATCH] Assign the correct pci id range to virtio_pci Date: Mon, 27 Apr 2009 11:01:13 +0200 Message-ID: <49F57459.7070409@redhat.com> References: <1240571860-13832-1-git-send-email-pktoss@gmail.com> <49F1BC55.9080605@codemonkey.ws> <49F55DD1.8020506@redhat.com> <1295ed070904270139g5dc0b634hc7f13b38c814bccd@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , kvm@vger.kernel.org To: Pantelis Koukousoulas Return-path: Received: from mx2.redhat.com ([66.187.237.31]:54701 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753314AbZD0JBS (ORCPT ); Mon, 27 Apr 2009 05:01:18 -0400 In-Reply-To: <1295ed070904270139g5dc0b634hc7f13b38c814bccd@mail.gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On 04/27/09 10:39, Pantelis Koukousoulas wrote: >> I'd suggest to exclude the experimental range by default (enable via module >> parameter) to make clear it isn't for regular use. > > Module parameter on what? virtio_pci.ko Then you'll do something like this ... echo "options virtio_pci experimental=1" >> /etc/modprobe.d/virtio.conf ... to enable the experimental IDs. > The module parameter parsing code is afaict > provided by the end-driver (e.g., virtio-net) which only speaks virtio and has > no idea there is an actual PCI device in the backend. virtio_pci is a separate module and can have parameters too. cheers, Gerd