From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH RFC 0/8] virtio: add guest MSI-X support Date: Tue, 28 Apr 2009 09:47:14 +0300 Message-ID: <49F6A672.8050704@redhat.com> References: <20090427123136.GA1152@redhat.com> <200904271600.30599.borntraeger@de.ibm.com> <49F5CA08.6060003@redhat.com> <20090427153936.GA2276@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Christian Borntraeger , Rusty Russell , virtualization@lists.linux-foundation.org, Anthony Liguori , kvm@vger.kernel.org To: "Michael S. Tsirkin" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:44197 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755554AbZD1Grn (ORCPT ); Tue, 28 Apr 2009 02:47:43 -0400 In-Reply-To: <20090427153936.GA2276@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Michael S. Tsirkin wrote: >> That saves us the new API (at the expense of a lot more code, but with >> added flexibility). >> > > So we'll probably need to rename request_vqs to request_vectors, > but we probably still need the driver to pass the number of > vectors it wants to the transport. Right? > > I don't think so - virtio will provide the number of interrupts it supports, and virtio-net will tell it to bind ring X to interrupt Y. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.