From: Avi Kivity <avi@redhat.com>
To: Mark McLoughlin <markmc@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] kvm: qemu: net: unbreak tap networking
Date: Tue, 28 Apr 2009 11:58:50 +0300 [thread overview]
Message-ID: <49F6C54A.1060005@redhat.com> (raw)
In-Reply-To: <1240908500-25598-1-git-send-email-markmc@redhat.com>
Mark McLoughlin wrote:
> A recent merge broke tap networking because qemu_send_packet()
> now always returns -EAGAIN causing tap to try and resend the
> same packet forever.
>
> Fix by having qemu_send_packet() return the status from the
> qemu_deliver_packet() of the packet in question, rather than
> any packets which happened to have been queued up during the
> delivery of the original packet.
>
Applied, thanks.
What's the outlook on converging with upstream here? Otherwise I'll
keep breaking net on every merge.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2009-04-28 8:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 8:48 [PATCH] kvm: qemu: net: unbreak tap networking Mark McLoughlin
2009-04-28 8:58 ` Avi Kivity [this message]
2009-04-28 10:10 ` Mark McLoughlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F6C54A.1060005@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=markmc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox