From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 7/7] kvm x86: report 1GB page support to userspace
Date: Tue, 28 Apr 2009 13:10:04 +0300
Message-ID: <49F6D5FC.90106@redhat.com>
References: <1240574327-21575-1-git-send-email-joerg.roedel@amd.com> <1240574327-21575-8-git-send-email-joerg.roedel@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <marcelo@kvack.or>, linux-kernel@vger.kernel.org,
	kvm@vger.kernel.org
To: Joerg Roedel <joerg.roedel@amd.com>
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S1757938AbZD1KKb@vger.kernel.org>
In-Reply-To: <1240574327-21575-8-git-send-email-joerg.roedel@amd.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

Joerg Roedel wrote:
> If userspace knows that the kernel part supports 1GB pages it can enable
> the corresponding cpuid bit so that guests actually use GB pages.
>   

Why not do everything via KVM_GET_SUPPORTED_CPUID2 and virtualized 
cpuid?  We can enable it in the kernel unconditionally.


-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.