From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/7] KVM support for 1GB pages v2 Date: Tue, 28 Apr 2009 13:16:07 +0300 Message-ID: <49F6D767.9050801@redhat.com> References: <1240574327-21575-1-git-send-email-joerg.roedel@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , linux-kernel@vger.kernel.org, kvm@vger.kernel.org To: Joerg Roedel Return-path: Received: from mx2.redhat.com ([66.187.237.31]:55964 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758957AbZD1KQK (ORCPT ); Tue, 28 Apr 2009 06:16:10 -0400 In-Reply-To: <1240574327-21575-1-git-send-email-joerg.roedel@amd.com> Sender: kvm-owner@vger.kernel.org List-ID: Joerg Roedel wrote: > Hi, > > this is the second version of the patches implementing support for 1GB > pages in KVM. There are too many changes to the first version to mention > them all here. The core support was rewritten to work with mapping > levels instead of page sizes. This was the main part of the change. > The patches still only support KVM with nested paging enabled What is missing to get shadow paging working with this? I don't think it's particularly important (it will be pretty hard to find a GB page without any shadowed pages in it), but I don't like arbitrary constraints. walk_addr() needs to change to support GB pages, did I miss it in the patchset? -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.