Re: kvm-kmod.git

Michael S. Tsirkin
2009-04-28T10:35:11Z

On Tue, Apr 28, 2009 at 01:24:44PM +0300, Avi Kivity wrote:
> Michael S. Tsirkin wrote:
>> On Mon, Apr 27, 2009 at 03:32:29PM +0300, Avi Kivity wrote:
>>
>>> This is a small git repository for the kvm external module kit.
>>>
>>
>> So, I am building on a host with CONFIG_KVM_TRACE set in its
>> kernel, but I run configure without enabling kvm trace.
>> As a result the module fails to link:
>>
>> WARNING: "kvm_trace_ioctl" [/home/mtsirkin/scm/kvm-kmod/x86/kvm.ko] undefined!
>> WARNING: "kvm_trace_cleanup" [/home/mtsirkin/scm/kvm-kmod/x86/kvm.ko] undefined!
>>
>> I think you need to undef CONFIG_KVM_TRACE somewhere to override the
>> value set in autoconf.h?
>>
>
> Or maybe, add a s/CONFIG_KVM_TRACE/CONFIG_KMOD_KVM_TRACE/ to make the
> two options independent.

You decide. I also wonder what happens if one tries to build on
a machine with kvm built into kernel. Ideally one would get
a clear error message.

--
MST