From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 03/04] qemu-kvm: Remove the dependency for phys_ram_base for ipf.c Date: Tue, 28 Apr 2009 15:49:25 +0300 Message-ID: <49F6FB55.3000503@redhat.com> References: <706158FABBBA044BAD4FE898A02E4BC236A2BC04@pdsmsx503.ccr.corp.intel.com> <49F6D13C.1060908@redhat.com> <706158FABBBA044BAD4FE898A02E4BC236A2BC2D@pdsmsx503.ccr.corp.intel.com> <49F6E2DC.3070405@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Zhang, Xiantao" , "kvm-ia64@vger.kernel.org" , "kvm@vger.kernel.org" To: Jes Sorensen Return-path: Received: from mx2.redhat.com ([66.187.237.31]:43243 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755148AbZD1Mt0 (ORCPT ); Tue, 28 Apr 2009 08:49:26 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: Jes Sorensen wrote: >>>>>> "Avi" == Avi Kivity writes: >>>>>> > > Avi> Zhang, Xiantao wrote: > >>>> qemu_get_ram_ptr() returns a pointer. Don't cast it to a >>>> ram_addr_t, leave it a pointer. >>>> >>>> But why not use cpu_physical_memory_write() (or >>>> cpu_physical_memory_write_rom())? It's much simpler and cleaner. >>>> >>>> >>> Good suggestion! I just followed the original logic. Updated the >>> patch. Xiantao >>> > > Avi> Thanks, applied. > > Hi, > > I am not crazy about this patch. You need to use cpy_physical_memory_rw() > in the hob and nvram code too, not just in the ipf.c code. > > What about the flush_icache_range() call you removed - is it safe to > just discard that? > > I was in the process of working through this myself, but I am not > quite finished. If you don't mind waiting a couple hours, I should > have something a fair bit simpler to solve the same problem. > > Biggest issue is the flush_icache_range() one. > > I haven't pushed this out yet, so I can apply a replacement patch. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.