From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH RFC 0/8] virtio: add guest MSI-X support
Date: Tue, 28 Apr 2009 20:51:08 +0300
Message-ID: <49F7420C.5070505@redhat.com>
References: <20090427123136.GA1152@redhat.com> <200904271600.30599.borntraeger@de.ibm.com> <49F5CA08.6060003@redhat.com> <20090427153936.GA2276@redhat.com> <49F6A672.8050704@redhat.com> <20090428174152.GA7604@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
	Rusty Russell <rusty@rustcorp.com.au>,
	virtualization@lists.linux-foundation.org,
	Anthony Liguori <anthony@codemonkey.ws>, kvm@vger.kernel.org
To: "Michael S. Tsirkin" <mst@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:43263 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752237AbZD1Rxh (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 28 Apr 2009 13:53:37 -0400
In-Reply-To: <20090428174152.GA7604@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Michael S. Tsirkin wrote:
> This does not work for MSIX - in linux, you must map all MSI-X entries
> to interrupt vectors upfront.
>   

What?  that's very inflexible.

Can you point me at the code?

> So what I see is transports providing something like:
>
> struct virtio_interrupt_mapping {
> 	int virtqueue;
> 	int interrupt;
> };
>
> map_vqs_to_interrupt(dev, struct virtio_interrupt_mapping *, int nvirtqueues);
> unmap_vqs(dev);
>   

Isn't that the same thing?  Please explain the flow.


-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.