From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [PATCH RFC 0/8] virtio: add guest MSI-X support
Date: Tue, 28 Apr 2009 14:56:15 -0500
Message-ID: <49F75F5F.1000501@codemonkey.ws>
References: <20090427123136.GA1152@redhat.com> <200904271600.30599.borntraeger@de.ibm.com> <49F5CA08.6060003@redhat.com> <20090427153936.GA2276@redhat.com> <49F6A672.8050704@redhat.com> <20090428174152.GA7604@redhat.com> <49F7420C.5070505@redhat.com> <20090428180248.GB7604@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Avi Kivity <avi@redhat.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Rusty Russell <rusty@rustcorp.com.au>,
	virtualization@lists.linux-foundation.org, kvm@vger.kernel.org
To: "Michael S. Tsirkin" <mst@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from wa-out-1112.google.com ([209.85.146.176]:42869 "EHLO
	wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754692AbZD1T4U (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 28 Apr 2009 15:56:20 -0400
Received: by wa-out-1112.google.com with SMTP id j5so386516wah.21
        for <kvm@vger.kernel.org>; Tue, 28 Apr 2009 12:56:20 -0700 (PDT)
In-Reply-To: <20090428180248.GB7604@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Michael S. Tsirkin wrote:
> So to map vq 0 to vector 0, vq 1 to vector 1 and vq 2 to vector 2 the driver would do:
>
> struct virtio_interrupt_mapping mapping[3] = { {0, 0}, {1, 1}, {2, 2} };
> vec = map_vqs_to_interrupt(dev, mapping, 3);
> if (vec) {
>   error handling
> }
>
> and then find_vq as usual.
>   

Is it possible to just delay the msix enablement until after the queues 
have been finalized (IOW in virtio-pci.c:vp_finalize_features)?

Regards,

Anthony Liguori