Zhang, Xiantao wrote: > Avi Kivity wrote: >> I haven't pushed this out yet, so I can apply a replacement patch. > > We don't need flush_icache_range here, because I believe it is called in cpu_physical_memory_write. > Xiantao Hi Xiantao, Good point, I hadn't spotted that, and worse I mangled flush_icache_range() in the process, trying to be smart :-( Here's a version without cache flush changes, it should do the right thing. We still need to look at the nvram stuff, but that is broken in all setups currently. What do you think of this one? Cheers, Jes