From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jes Sorensen Subject: Re: [PATCH 02/04] qemu-kvm: Add header files for ia64. Date: Wed, 29 Apr 2009 11:51:44 +0200 Message-ID: <49F82330.3090302@sgi.com> References: <706158FABBBA044BAD4FE898A02E4BC236A2BC05@pdsmsx503.ccr.corp.intel.com> <706158FABBBA044BAD4FE898A02E4BC236A2C0C6@pdsmsx503.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Avi Kivity , "kvm-ia64@vger.kernel.org" , "kvm@vger.kernel.org" To: "Zhang, Xiantao" Return-path: Received: from relay3.sgi.com ([192.48.156.57]:35814 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754051AbZD2Jvs (ORCPT ); Wed, 29 Apr 2009 05:51:48 -0400 In-Reply-To: <706158FABBBA044BAD4FE898A02E4BC236A2C0C6@pdsmsx503.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Zhang, Xiantao wrote: > Hi, Jes > There should be no issue here. You may refer to qemu-kvm/kvm/kernel/arch/x86/include/asm/kvm.h, and it also includes this stuff. I remebered this stuff was used to solve the issues when uses kernel header files in userspace and the author should be Avi:-) You know, kernel header may include CONFIG_$ARCH macros but they are meaningless in userspace, so needs a way to solve the gap. But anyway we can do some cleanup or introduce new ways to solve the issue. > Xiantao Hi Xiantao, I noticed it's in the x86 code as well - but I still think it's silly to add to the ia64 tree when we don't need it. Of course, Avi should fix up his headers too :-) Cheers, Jes