From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v2 00/16] interrupt injection rework Date: Wed, 29 Apr 2009 12:33:09 +0200 Message-ID: <49F82CE5.6030100@siemens.com> References: <1240325111-3725-1-git-send-email-gleb@redhat.com> <49F594CE.6050904@redhat.com> <49F81E46.2020104@siemens.com> <20090429102201.GA19927@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Avi Kivity , kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from gecko.sbs.de ([194.138.37.40]:16030 "EHLO gecko.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751545AbZD2Kd3 (ORCPT ); Wed, 29 Apr 2009 06:33:29 -0400 In-Reply-To: <20090429102201.GA19927@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Gleb Natapov wrote: > On Wed, Apr 29, 2009 at 11:30:46AM +0200, Jan Kiszka wrote: >> Avi Kivity wrote: >>> Gleb Natapov wrote: >>>> Hi, >>>> >>>> This patch series aims to consolidate IRQ injection code for in kernel >>>> IRQ chip and userspace one. Also to move IRQ injection logic from >>>> SVM/VMX specific code to x86.c. >>>> >>> Applied all, thanks for this excellent patchset. >>> >> Hmm, to which branch? Or did you just forget to also push it... >> >> Gleb, what is your current schedule regarding single-step on NMI iret? >> > I was going to look at it shortly. BTW there are other cases when single > stepping is required. For instance if exception is injected and there is > NMI pending NMI should be injected immediately after exception handler > is started, but currently it happens only after a next exit. So we basically need an NMI windows notification that not only triggers on iret completion. Sounds OK. Then I would say: once there is anything to test, even if it's early stuff, throw it over. Thanks, Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux