Re: [PATCH v2 00/16] interrupt injection rework

Gleb Natapov
2009-04-29T10:35:14Z

On Wed, Apr 29, 2009 at 12:33:09PM +0200, Jan Kiszka wrote:
> Gleb Natapov wrote:
> > On Wed, Apr 29, 2009 at 11:30:46AM +0200, Jan Kiszka wrote:
> >> Avi Kivity wrote:
> >>> Gleb Natapov wrote:
> >>>> Hi,
> >>>>
> >>>> This patch series aims to consolidate IRQ injection code for in kernel
> >>>> IRQ chip and userspace one. Also to move IRQ injection logic from
> >>>> SVM/VMX specific code to x86.c.
> >>>>
> >>> Applied all, thanks for this excellent patchset.
> >>>
> >> Hmm, to which branch? Or did you just forget to also push it...
> >>
> >> Gleb, what is your current schedule regarding single-step on NMI iret?
> >>
> > I was going to look at it shortly. BTW there are other cases when single
> > stepping is required. For instance if exception is injected and there is
> > NMI pending NMI should be injected immediately after exception handler
> > is started, but currently it happens only after a next exit.
>
> So we basically need an NMI windows notification that not only triggers
> on iret completion. Sounds OK.
>
But we don't have one on SVM :(

> Then I would say: once there is anything to test, even if it's early
> stuff, throw it over.
>
OK.

--
Gleb.