Re: [PATCH v2 00/16] interrupt injection rework

Jan Kiszka
2009-04-29T10:46:32Z

Gleb Natapov wrote:
> On Wed, Apr 29, 2009 at 12:33:09PM +0200, Jan Kiszka wrote:
>> Gleb Natapov wrote:
>>> On Wed, Apr 29, 2009 at 11:30:46AM +0200, Jan Kiszka wrote:
>>>> Avi Kivity wrote:
>>>>> Gleb Natapov wrote:
>>>>>> Hi,
>>>>>>
>>>>>> This patch series aims to consolidate IRQ injection code for in kernel
>>>>>> IRQ chip and userspace one. Also to move IRQ injection logic from
>>>>>> SVM/VMX specific code to x86.c.
>>>>>>
>>>>> Applied all, thanks for this excellent patchset.
>>>>>
>>>> Hmm, to which branch? Or did you just forget to also push it...
>>>>
>>>> Gleb, what is your current schedule regarding single-step on NMI iret?
>>>>
>>> I was going to look at it shortly. BTW there are other cases when single
>>> stepping is required. For instance if exception is injected and there is
>>> NMI pending NMI should be injected immediately after exception handler
>>> is started, but currently it happens only after a next exit.
>> So we basically need an NMI windows notification that not only triggers
>> on iret completion. Sounds OK.
>>
> But we don't have one on SVM :(

Yeah - and I was so optimistic that AMD managed to deliver an easily
implementable interface right from the beginning. Intel required two
steps, and the result has still some traps. Now it turns out also AMD
complicated NMI virtualization, IMHO needlessly. Well, but as we all
constantly seek for challenges... ;)

Jan

--
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux