From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jes Sorensen Subject: Re: [PATCH 03/04] qemu-kvm: Remove the dependency for phys_ram_base for ipf.c Date: Thu, 30 Apr 2009 11:11:03 +0200 Message-ID: <49F96B27.8050101@sgi.com> References: <706158FABBBA044BAD4FE898A02E4BC236A2BC04@pdsmsx503.ccr.corp.intel.com> <49F6D13C.1060908@redhat.com> <706158FABBBA044BAD4FE898A02E4BC236A2BC2D@pdsmsx503.ccr.corp.intel.com> <49F6E2DC.3070405@redhat.com> <49F6FB55.3000503@redhat.com> <706158FABBBA044BAD4FE898A02E4BC236A2BD9A@pdsmsx503.ccr.corp.intel.com> <49F80DFC.5060006@sgi.com> <706158FABBBA044BAD4FE898A02E4BC236A2C04D@pdsmsx503.ccr.corp.intel.com> <49F812EF.5060006@sgi.com> <706158FABBBA044BAD4FE898A02E4BC236A2C11C@pdsmsx503.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Avi Kivity , "kvm-ia64@vger.kernel.org" , "kvm@vger.kernel.org" To: "Zhang, Xiantao" Return-path: Received: from relay2.sgi.com ([192.48.179.30]:38623 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752834AbZD3JLJ (ORCPT ); Thu, 30 Apr 2009 05:11:09 -0400 In-Reply-To: <706158FABBBA044BAD4FE898A02E4BC236A2C11C@pdsmsx503.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Zhang, Xiantao wrote: > Jes Sorensen wrote: >> The main difference is that my patch cleans up the interfaces and >> calls to the various functions, and removes a bunch of global >> variables as well. > > I still can't see the difference with the patch in Avi's tree except nvram stuff. And I believe the global variable you mentioned should be only used for nvram. So I propose an incremental patch for that. :) Hi Xiantao, I cannot see your patch in Avi's tree, would you mind sending me the latest version by email, so I can look into this? Thanks, Jes