From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 03/21] Remove use of signalfd in block-raw-posix.c
Date: Thu, 30 Apr 2009 12:28:23 +0300
Message-ID: <49F96F37.2070002@redhat.com>
References: <1241040038-17183-1-git-send-email-aliguori@us.ibm.com> <1241040038-17183-4-git-send-email-aliguori@us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org
To: Anthony Liguori <aliguori@us.ibm.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:34554 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751900AbZD3J2b (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 30 Apr 2009 05:28:31 -0400
In-Reply-To: <1241040038-17183-4-git-send-email-aliguori@us.ibm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Anthony Liguori wrote:
> We don't use signalfd in upstream QEMU.  Instead, we always emulate it.
>   

With an extra thread -> so an extra context switch.

> It's not necessarily a bad thing to use signalfd, but this is something that
> should be done upstream.  It certainly does qemu-kvm no harm to use the upstream
> code.
>   

It will introduce a (likely minor, but real) performance regression.

Instead of this, why not apply the reverse patch to qemu.git?


-- 
error compiling committee.c: too many arguments to function