From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 11/21] Remove unused variables in vga.c Date: Thu, 30 Apr 2009 12:33:01 +0300 Message-ID: <49F9704D.3090400@redhat.com> References: <1241040038-17183-1-git-send-email-aliguori@us.ibm.com> <1241040038-17183-12-git-send-email-aliguori@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Anthony Liguori Return-path: Received: from mx2.redhat.com ([66.187.237.31]:56254 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751959AbZD3JdE (ORCPT ); Thu, 30 Apr 2009 05:33:04 -0400 In-Reply-To: <1241040038-17183-12-git-send-email-aliguori@us.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: Anthony Liguori wrote: > Signed-off-by: Anthony Liguori > --- > hw/vga.c | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/hw/vga.c b/hw/vga.c > index 4931b69..d96f1be 100644 > --- a/hw/vga.c > +++ b/hw/vga.c > @@ -1585,12 +1585,11 @@ static void vga_sync_dirty_bitmap(VGAState *s) > */ > static void vga_draw_graphic(VGAState *s, int full_update) > { > - int y1, y, update, linesize, y_start, double_scan, mask, depth; > - int width, height, shift_control, line_offset, bwidth, bits; > + int y1, y, update, page_min, page_max, linesize, y_start, double_scan, mask, depth; > + int width, height, shift_control, line_offset, page0, page1, bwidth, bits; > int disp_width, multi_scan, multi_run; > uint8_t *d; > uint32_t v, addr1, addr; > - long page0, page1, page_min, page_max; > vga_draw_line_func *vga_draw_line; > This introduces a regression with >4GB guests. I resolved this by posting a patch to qemu; see 12c7e75a7c. Are you using an outdated checkout? -- error compiling committee.c: too many arguments to function