From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 13/21] Remove virtio-console PIF change Date: Thu, 30 Apr 2009 12:40:39 +0300 Message-ID: <49F97217.3080206@redhat.com> References: <1241040038-17183-1-git-send-email-aliguori@us.ibm.com> <1241040038-17183-14-git-send-email-aliguori@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Anthony Liguori Return-path: Received: from mx2.redhat.com ([66.187.237.31]:60758 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754031AbZD3Jkl (ORCPT ); Thu, 30 Apr 2009 05:40:41 -0400 In-Reply-To: <1241040038-17183-14-git-send-email-aliguori@us.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: Anthony Liguori wrote: > If this change should happen, it should happen in upstream QEMU. > > Signed-off-by: Anthony Liguori > --- > hw/virtio-console.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/virtio-console.c b/hw/virtio-console.c > index 89e8be0..b263281 100644 > --- a/hw/virtio-console.c > +++ b/hw/virtio-console.c > @@ -132,7 +132,7 @@ void *virtio_console_init(PCIBus *bus, CharDriverState *chr) > PCI_DEVICE_ID_VIRTIO_CONSOLE, > PCI_VENDOR_ID_REDHAT_QUMRANET, > VIRTIO_ID_CONSOLE, > - PCI_CLASS_OTHERS, 0x00, > + PCI_CLASS_DISPLAY_OTHER, 0x00, > 0, sizeof(VirtIOConsole)); > if (s == NULL) > return NULL; > Since virtio-console is not enabled by default, it isn't needed, so I'll apply this. But if it were needed, there's no reason to introduce regressions into qemu-kvm.git. -- error compiling committee.c: too many arguments to function