From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 11/21] Remove unused variables in vga.c Date: Thu, 30 Apr 2009 08:09:05 -0500 Message-ID: <49F9A2F1.1040005@us.ibm.com> References: <1241040038-17183-1-git-send-email-aliguori@us.ibm.com> <1241040038-17183-12-git-send-email-aliguori@us.ibm.com> <49F9704D.3090400@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from e7.ny.us.ibm.com ([32.97.182.137]:35021 "EHLO e7.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761219AbZD3NJK (ORCPT ); Thu, 30 Apr 2009 09:09:10 -0400 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e7.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n3UCwWoc019664 for ; Thu, 30 Apr 2009 08:58:32 -0400 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n3UD99Gc147526 for ; Thu, 30 Apr 2009 09:09:09 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n3UD99FB013348 for ; Thu, 30 Apr 2009 09:09:09 -0400 In-Reply-To: <49F9704D.3090400@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: >> @@ -1585,12 +1585,11 @@ static void vga_sync_dirty_bitmap(VGAState *s) >> */ >> static void vga_draw_graphic(VGAState *s, int full_update) >> { >> - int y1, y, update, linesize, y_start, double_scan, mask, depth; >> - int width, height, shift_control, line_offset, bwidth, bits; >> + int y1, y, update, page_min, page_max, linesize, y_start, >> double_scan, mask, depth; >> + int width, height, shift_control, line_offset, page0, page1, >> bwidth, bits; >> int disp_width, multi_scan, multi_run; >> uint8_t *d; >> uint32_t v, addr1, addr; >> - long page0, page1, page_min, page_max; >> vga_draw_line_func *vga_draw_line; >> > > This introduces a regression with >4GB guests. I resolved this by > posting a patch to qemu; see 12c7e75a7c. Are you using an outdated > checkout? Oh, I understand what's happening now. It took me a while to see that we're changing the type of variables from int to long. -- Regards, Anthony Liguori