From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 14/21] Remove -cpu-vendor-string Date: Thu, 30 Apr 2009 08:10:38 -0500 Message-ID: <49F9A34E.8050506@us.ibm.com> References: <1241040038-17183-1-git-send-email-aliguori@us.ibm.com> <1241040038-17183-15-git-send-email-aliguori@us.ibm.com> <49F9725A.8080908@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from e6.ny.us.ibm.com ([32.97.182.146]:53331 "EHLO e6.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756460AbZD3NKl (ORCPT ); Thu, 30 Apr 2009 09:10:41 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e6.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n3UDChLn006160 for ; Thu, 30 Apr 2009 09:12:43 -0400 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n3UDAftJ153378 for ; Thu, 30 Apr 2009 09:10:41 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n3UDAeqO020443 for ; Thu, 30 Apr 2009 09:10:40 -0400 In-Reply-To: <49F9725A.8080908@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: > Anthony Liguori wrote: >> This isn't in upstream QEMU and is of little utility to KVM. It's >> unlikely >> to appear in upstream QEMU either. >> > > Since we allow overriding cpuid flags, why not the vendor string? > It's necessary for cpu passthrough. > But we don't allow explicit override of cpuid flags today. We support choosing CPU models which include vendor id and cpuid flags. Introducing a host CPU model would be acceptable and would more accurately achieve cpu passthrough. -- Regards, Anthony Liguori