From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 17/21] Remove #define __user in usb-linux.c Date: Thu, 30 Apr 2009 08:11:10 -0500 Message-ID: <49F9A36E.4010709@us.ibm.com> References: <1241040038-17183-1-git-send-email-aliguori@us.ibm.com> <1241040038-17183-18-git-send-email-aliguori@us.ibm.com> <49F972C5.2040408@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from e37.co.us.ibm.com ([32.97.110.158]:60706 "EHLO e37.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755717AbZD3NLR (ORCPT ); Thu, 30 Apr 2009 09:11:17 -0400 Received: from d03relay05.boulder.ibm.com (d03relay05.boulder.ibm.com [9.17.195.107]) by e37.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n3UDAi72015902 for ; Thu, 30 Apr 2009 07:10:44 -0600 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay05.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n3UDBFdg035088 for ; Thu, 30 Apr 2009 07:11:15 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n3UDBB00014438 for ; Thu, 30 Apr 2009 07:11:12 -0600 In-Reply-To: <49F972C5.2040408@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: > Anthony Liguori wrote: >> This has been consistently nacked in upstream QEMU. >> >> Signed-off-by: Anthony Liguori >> --- >> usb-linux.c | 4 ---- >> 1 files changed, 0 insertions(+), 4 deletions(-) >> >> diff --git a/usb-linux.c b/usb-linux.c >> index 26643bd..70d7a1c 100644 >> --- a/usb-linux.c >> +++ b/usb-linux.c >> @@ -34,10 +34,6 @@ >> #include "qemu-timer.h" >> #include "monitor.h" >> >> -#if defined(__linux__) >> -#define __user >> -#endif >> - >> > > This will introduce a regression into qemu-kvm.git. It won't because -D__user is in CFLAGS. -- Regards, Anthony Liguori