From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 17/21] Remove #define __user in usb-linux.c Date: Thu, 30 Apr 2009 16:17:57 +0300 Message-ID: <49F9A505.9030807@redhat.com> References: <1241040038-17183-1-git-send-email-aliguori@us.ibm.com> <1241040038-17183-18-git-send-email-aliguori@us.ibm.com> <49F972C5.2040408@redhat.com> <49F9A36E.4010709@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Anthony Liguori Return-path: Received: from mx2.redhat.com ([66.187.237.31]:40432 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756351AbZD3NSH (ORCPT ); Thu, 30 Apr 2009 09:18:07 -0400 In-Reply-To: <49F9A36E.4010709@us.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: Anthony Liguori wrote: > Avi Kivity wrote: >> Anthony Liguori wrote: >>> This has been consistently nacked in upstream QEMU. >>> >>> -#if defined(__linux__) >>> -#define __user >>> -#endif >>> - >>> >> >> This will introduce a regression into qemu-kvm.git. > > It won't because -D__user is in CFLAGS. > Ah, ok, will apply. But that's not in upstream either. -- error compiling committee.c: too many arguments to function