From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 14/21] Remove -cpu-vendor-string Date: Thu, 30 Apr 2009 08:26:22 -0500 Message-ID: <49F9A6FE.10301@us.ibm.com> References: <1241040038-17183-1-git-send-email-aliguori@us.ibm.com> <1241040038-17183-15-git-send-email-aliguori@us.ibm.com> <49F9725A.8080908@redhat.com> <49F9A34E.8050506@us.ibm.com> <49F9A4A5.8010500@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from e36.co.us.ibm.com ([32.97.110.154]:34958 "EHLO e36.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756355AbZD3N0g (ORCPT ); Thu, 30 Apr 2009 09:26:36 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e36.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n3UDP2Hd030565 for ; Thu, 30 Apr 2009 07:25:02 -0600 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n3UDQSnm226032 for ; Thu, 30 Apr 2009 07:26:32 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n3UDQQoc023722 for ; Thu, 30 Apr 2009 07:26:27 -0600 In-Reply-To: <49F9A4A5.8010500@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: > Anthony Liguori wrote: >>>> This isn't in upstream QEMU and is of little utility to KVM. It's >>>> unlikely >>>> to appear in upstream QEMU either. >>>> >>> >>> Since we allow overriding cpuid flags, why not the vendor string? >>> It's necessary for cpu passthrough. >>> >> But we don't allow explicit override of cpuid flags today. We >> support choosing CPU models which include vendor id and cpuid flags. > > I think we allow "-cpu qemu64,-nx" for example. Funny enough, -cpu qemu64,vendor="AuthenticAMD" already works today. So yeah, there's no reason to carry -cpu-vendor-string anymore. -- Regards, Anthony Liguori