From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 03/21] Remove use of signalfd in block-raw-posix.c Date: Thu, 30 Apr 2009 16:36:09 +0300 Message-ID: <49F9A949.2040609@redhat.com> References: <1241040038-17183-1-git-send-email-aliguori@us.ibm.com> <1241040038-17183-4-git-send-email-aliguori@us.ibm.com> <49F96F37.2070002@redhat.com> <49F99F8A.8010806@codemonkey.ws> <49F9A1FC.2060705@redhat.com> <49F9A786.5020306@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Anthony Liguori Return-path: Received: from mx2.redhat.com ([66.187.237.31]:41736 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762996AbZD3NgM (ORCPT ); Thu, 30 Apr 2009 09:36:12 -0400 In-Reply-To: <49F9A786.5020306@us.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: Anthony Liguori wrote: >> >> Oh okay. But signal delivery is slow; for example the FPU needs to >> be reset. > > Is it really justified to add all of this extra code (including > signalfd emulation) for something that probably isn't even measurable? We don't have to add signalfd emulation; we can simply use signal+pipe in that case. We won't know if it's measurable or not until we measure it (or not). > > I like using wiz-bang features of Linux as much as the next guy, but I > think we're stretching to justify it here :-) > I think it's worth it in this case. It will become more important in time, too. -- error compiling committee.c: too many arguments to function