Re: [PATCH 11/21] Remove unused variables in vga.c

Avi Kivity
2009-04-30T09:33:04Z

Anthony Liguori wrote:
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> ---
> hw/vga.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/hw/vga.c b/hw/vga.c
> index 4931b69..d96f1be 100644
> --- a/hw/vga.c
> +++ b/hw/vga.c
> @@ -1585,12 +1585,11 @@ static void vga_sync_dirty_bitmap(VGAState *s)
> */
> static void vga_draw_graphic(VGAState *s, int full_update)
> {
> - int y1, y, update, linesize, y_start, double_scan, mask, depth;
> - int width, height, shift_control, line_offset, bwidth, bits;
> + int y1, y, update, page_min, page_max, linesize, y_start, double_scan, mask, depth;
> + int width, height, shift_control, line_offset, page0, page1, bwidth, bits;
> int disp_width, multi_scan, multi_run;
> uint8_t *d;
> uint32_t v, addr1, addr;
> - long page0, page1, page_min, page_max;
> vga_draw_line_func *vga_draw_line;
>

This introduces a regression with >4GB guests. I resolved this by
posting a patch to qemu; see 12c7e75a7c. Are you using an outdated
checkout?

--
error compiling committee.c: too many arguments to function