Re: [PATCH 14/21] Remove -cpu-vendor-string

Avi Kivity
2009-04-30T13:16:32Z

Anthony Liguori wrote:
>>> This isn't in upstream QEMU and is of little utility to KVM. It's
>>> unlikely
>>> to appear in upstream QEMU either.
>>>
>>
>> Since we allow overriding cpuid flags, why not the vendor string?
>> It's necessary for cpu passthrough.
>>
> But we don't allow explicit override of cpuid flags today. We support
> choosing CPU models which include vendor id and cpuid flags.

I think we allow "-cpu qemu64,-nx" for example.

>
> Introducing a host CPU model would be acceptable and would more
> accurately achieve cpu passthrough.
>

I agree that "-cpu host[,modifiers]" is desirable. But I don't see why
we shouldn't support finegrained control.

It's probably better done through a "-cpu blah,-nx,vendorid=foobar"
rather than a separate option.

--
error compiling committee.c: too many arguments to function