Re: [PATCH 03/21] Remove use of signalfd in block-raw-posix.c

Avi Kivity
2009-04-30T13:36:12Z

Anthony Liguori wrote:
>>
>> Oh okay. But signal delivery is slow; for example the FPU needs to
>> be reset.
>
> Is it really justified to add all of this extra code (including
> signalfd emulation) for something that probably isn't even measurable?

We don't have to add signalfd emulation; we can simply use signal+pipe
in that case.

We won't know if it's measurable or not until we measure it (or not).

>
> I like using wiz-bang features of Linux as much as the next guy, but I
> think we're stretching to justify it here :-)
>

I think it's worth it in this case. It will become more important in
time, too.

--
error compiling committee.c: too many arguments to function