Re: [PATCH 11/21] Remove unused variables in vga.c

Anthony Liguori
2009-04-30T13:09:10Z

Avi Kivity wrote:
>> @@ -1585,12 +1585,11 @@ static void vga_sync_dirty_bitmap(VGAState *s)
>> */
>> static void vga_draw_graphic(VGAState *s, int full_update)
>> {
>> - int y1, y, update, linesize, y_start, double_scan, mask, depth;
>> - int width, height, shift_control, line_offset, bwidth, bits;
>> + int y1, y, update, page_min, page_max, linesize, y_start,
>> double_scan, mask, depth;
>> + int width, height, shift_control, line_offset, page0, page1,
>> bwidth, bits;
>> int disp_width, multi_scan, multi_run;
>> uint8_t *d;
>> uint32_t v, addr1, addr;
>> - long page0, page1, page_min, page_max;
>> vga_draw_line_func *vga_draw_line;
>>
>
> This introduces a regression with >4GB guests. I resolved this by
> posting a patch to qemu; see 12c7e75a7c. Are you using an outdated
> checkout?

Oh, I understand what's happening now. It took me a while to see that
we're changing the type of variables from int to long.

--
Regards,

Anthony Liguori