Re: [PATCH 13/21] Remove virtio-console PIF change

Avi Kivity
2009-04-30T09:40:41Z

Anthony Liguori wrote:
> If this change should happen, it should happen in upstream QEMU.
>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> ---
> hw/virtio-console.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/virtio-console.c b/hw/virtio-console.c
> index 89e8be0..b263281 100644
> --- a/hw/virtio-console.c
> +++ b/hw/virtio-console.c
> @@ -132,7 +132,7 @@ void *virtio_console_init(PCIBus *bus, CharDriverState *chr)
> PCI_DEVICE_ID_VIRTIO_CONSOLE,
> PCI_VENDOR_ID_REDHAT_QUMRANET,
> VIRTIO_ID_CONSOLE,
> - PCI_CLASS_OTHERS, 0x00,
> + PCI_CLASS_DISPLAY_OTHER, 0x00,
> 0, sizeof(VirtIOConsole));
> if (s == NULL)
> return NULL;
>

Since virtio-console is not enabled by default, it isn't needed, so I'll
apply this.

But if it were needed, there's no reason to introduce regressions into
qemu-kvm.git.

--
error compiling committee.c: too many arguments to function