Re: [PATCH 14/21] Remove -cpu-vendor-string

Avi Kivity
2009-04-30T13:33:04Z

Anthony Liguori wrote:
>>>>> This isn't in upstream QEMU and is of little utility to KVM. It's
>>>>> unlikely
>>>>> to appear in upstream QEMU either.
>>>>>
>>>>
>>>> Since we allow overriding cpuid flags, why not the vendor string?
>>>> It's necessary for cpu passthrough.
>>>>
>>> But we don't allow explicit override of cpuid flags today. We
>>> support choosing CPU models which include vendor id and cpuid flags.
>>
>> I think we allow "-cpu qemu64,-nx" for example.
>
> Funny enough, -cpu qemu64,vendor="AuthenticAMD" already works today.
> So yeah, there's no reason to carry -cpu-vendor-string anymore.
>

Applied, but had to reverse the sense of the commit log :)

--
error compiling committee.c: too many arguments to function