From mboxrd@z Thu Jan 1 00:00:00 1970 From: supriya kannery Subject: Re: [KVM-AUTOTEST] [PATCH] Iterate over reboot Date: Fri, 01 May 2009 14:48:02 +0530 Message-ID: <49FABE4A.3000900@in.ibm.com> References: <49ECC158.9070003@in.ibm.com> <49EF2DE6.5060006@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Uri Lublin Return-path: Received: from e28smtp06.in.ibm.com ([59.145.155.6]:46758 "EHLO e28smtp06.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754231AbZEAJZC (ORCPT ); Fri, 1 May 2009 05:25:02 -0400 Received: from d28relay04.in.ibm.com (d28relay04.in.ibm.com [9.184.220.61]) by e28smtp06.in.ibm.com (8.13.1/8.13.1) with ESMTP id n419P0N6030302 for ; Fri, 1 May 2009 14:55:00 +0530 Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63]) by d28relay04.in.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n419OxfQ1073296 for ; Fri, 1 May 2009 14:54:59 +0530 Received: from d28av01.in.ibm.com (loopback [127.0.0.1]) by d28av01.in.ibm.com (8.13.1/8.13.3) with ESMTP id n419Ox8V020178 for ; Fri, 1 May 2009 14:54:59 +0530 In-Reply-To: <49EF2DE6.5060006@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Uri Lublin wrote: > supriya kannery wrote: >> A patch for iterating over VM reboot >> > > I think adding iterations capability belongs to the infrastructure, > not the test itself. Implement it once in the infrastructure, instead > of once per test. > Also I think autotest has such a capability (adding iteration=n to > job.run_test parameters). > In the older version of kvm_runtest (kvm_runtest_old), the iteration parameter can be added to the corresponding job.runtest() of each test type (boot, reboot, migration).Different Class and execute function are defined for each test type in old runtest infrastructure which gives the flexibility of providing independent iteration values. But in the current infrastructure, I am not sure how we can apply that way to iterate each test type. My guess is, defining an iteration parameter under corresponding test type variant in the kvm_test.cfg file is one of the ways. Pls let me know if I overlooked anything here. Thanks, Supriya